Tablerow Rescales After All Elements Of Row Are Clicked

I am creating a Table of buttons, to control a LED Matrix via Bluetooth. I have found on the web Brian's Video Tutorials and followed his Dynamic Buttons and Images video to implem

Solution 1:

I think you're right about the layout parameters needing to change. This line

tableRow.setLayoutParams(new TableLayout.LayoutParams(TableLayout.LayoutParams.WRAP_CONTENT,TableLayout.LayoutParams.WRAP_CONTENT,1.0f));

would cause the row's height to shrink in size if no button had displayed text, which seems to be what's happening. The TableLayout.LayoutParams does support setting fixed width/height, which you could sensibly calculate by first getting the device's screen width/height and dividing accordingly.

Or, if that gets to cumbersome, you could set -- though this may be too much of a hack -- the default text in the TextViews in the "unset" buttons with some transparent text (e.g., "1,1") so that the height is the same as a set button. This SO answer answer shows how to make transparent text.

Solution 2:

I am certain that this is not a good solution for all cases. But just as I thought, the problem was with

 button.setLayoutParams(new TableRow.LayoutParams( TableRow.LayoutParams.MATCH_PARENT, TableRow.LayoutParams.MATCH_PARENT, 1.0f));

If I understand correctly after the entire row was clicked, since the LayoutParams change according to the MATCH_PARENT value, the TableRow rescales the whole row to meet this criteria,since the height of the entire row is the same now. Not sure if it happens exactly this way, but I think this is the case because of my solution.

My work around is to add specific values for the LayoutParams, instead of leaving it the system to figure it out:

button.setLayoutParams(new TableRow.LayoutParams( 75, 50, 1.0f));

I am aware this is not how it should be done. But since I have a deadline to met soon, I can't spend any more time with it. Most likely the correct way to do this is Jason's suggestion to get the screen size and calculate it. You can do this with:

Displaydisplay= getWindowManager().getDefaultDisplay(); Pointsize=newPoint();
display.getSize(size); 
intwidth= size.x; 
intheight= size.y;

The problem is to come up with a correct formula to calculate this values you can pass to the LayoutParam. If anyone can figure this out please do post your solution and I will accept that answer. At this point I accept Jason's suggestion.